perf: add path filtering to Nix validation CI job#518
Conversation
Skip Nix flake validation when no Nix-related files change. This speeds up CI for PRs that only touch source code, docs, or tests. Files that trigger Nix validation: - flake.nix, flake.lock - package.json, pnpm-lock.yaml - scripts/update-flake.sh - .github/workflows/ci.yml Uses dorny/paths-filter@v3 for change detection. Required-checks jobs updated to handle skipped status correctly.
📝 WalkthroughWalkthroughA new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review CompleteYour review story is ready! Comment !reviewfast on this PR to re-generate the story. |
Skip Nix flake validation when no Nix-related files change. This speeds up CI for PRs that only touch source code, docs, or tests. Files that trigger Nix validation: - flake.nix, flake.lock - package.json, pnpm-lock.yaml - scripts/update-flake.sh - .github/workflows/ci.yml Uses dorny/paths-filter@v3 for change detection. Required-checks jobs updated to handle skipped status correctly.
# By Tabish Bidiwale (57) and others # Via GitHub * main: (67 commits) fix(ci): use workflow_dispatch for polish release notes (Fission-AI#533) fix(changelog): convert markdown headers to bold text for proper formatting (Fission-AI#532) Version Packages (Fission-AI#531) Add changeset for project config and schema commands (Fission-AI#530) fix(config): handle null rules field in project config (Fission-AI#529) docs: update workflow docs and mark schema commands as experimental (Fission-AI#526) feat(cli): add schema management commands (Fission-AI#525) fix: Windows path compatibility in resolver tests (Fission-AI#524) change(schema-management-cli): proposal for schema management commands (Fission-AI#523) feat(resolver): add project-local schema support (Fission-AI#522) docs: add project-config demo guide (Fission-AI#521) feat(config): add project-level configuration via openspec/config.yaml (Fission-AI#499) fix: auto-trigger polish release notes on release publish (Fission-AI#519) perf: add path filtering to Nix validation CI job (Fission-AI#518) Version Packages (Fission-AI#517) Add changeset for v0.21 release (Fission-AI#516) fix: prevent implementation during explore mode (Fission-AI#515) OPSX apply: infer target change (Fission-AI#513) Refine opsx archive sync assessment (Fission-AI#514) feat: add nix flake support (sorry for this duplicate) (Fission-AI#459) ... # Conflicts: # src/core/templates/slash-command-templates.ts
Skip Nix flake validation when no Nix-related files change. This speeds up CI for PRs that only touch source code, docs, or tests. Files that trigger Nix validation: - flake.nix, flake.lock - package.json, pnpm-lock.yaml - scripts/update-flake.sh - .github/workflows/ci.yml Uses dorny/paths-filter@v3 for change detection. Required-checks jobs updated to handle skipped status correctly.
Summary
dorny/paths-filter@v3to detect changes to relevant filesFiles that trigger Nix validation
flake.nix,flake.lockpackage.json,pnpm-lock.yamlscripts/update-flake.sh.github/workflows/ci.ymlTesting
This PR changes
ci.yml, so the Nix validation will run on this PR (as expected).After merge, verify by creating a docs-only PR - the
nix-flake-validatejob should show as "Skipped" in the Actions UI.🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
✏️ Tip: You can customize this high-level summary in your review settings.